mirror of
https://github.com/FJurmanovic/sugarr.git
synced 2026-11-11 07:41:08 +00:00
Fix final review findings: key leak, model fallback, error resilience, docs
- ApiClient: strip query string from ApiError messages so API keys (e.g. TMDb's api_key query param) never leak into 500 response bodies or logs. - LlmTool: accept an optional defaultModel, wired from AppConfig's LLM_MODEL, so Langfuse prompts that omit a model config fall back to the configured LLM rather than silently requesting gpt-4o-mini. - RecommendationPipeline: restore the Go original's graceful degradation — library/Radarr fetch failures, per-suggestion TMDb resolution failures, and per-signal TMDb similarity/recommendation failures are now logged and skipped instead of aborting the whole run (applies to both runInternal and searchAsync). - RecommendationsController: validate the ?count= query param (must be a positive integer) instead of silently producing NaN. - Commit the Langfuse prompt definitions (langfuse/*.prompt.json) and add a README covering setup, prompt seeding, cache invalidation, and the HTTP API surface — the branch was not otherwise runnable by anyone but the author.
This commit is contained in:
@@ -101,4 +101,11 @@ describe('ApiClient', () => {
|
||||
const client = new TestClient('https://api.example.com');
|
||||
await expect(client.getThing(1)).rejects.toBeInstanceOf(ApiError);
|
||||
});
|
||||
|
||||
it('omits the query string (which may carry secrets) from the ApiError message', async () => {
|
||||
fetchMock.mockResolvedValue({ ok: false, status: 500, text: async () => 'boom' });
|
||||
|
||||
const client = new TestClient('https://api.example.com');
|
||||
await expect(client.getThing(1)).rejects.toThrow('GET https://api.example.com/things/1 returned 500');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user