security improvements

2025-06-29 21:59:41 +02:00
parent 7fdda06dba
commit caba5bae70
30 changed files with 3929 additions and 147 deletions
--- a/local/middleware/auth.go
+++ b/local/middleware/auth.go
@@ -1,9 +1,12 @@
 package middleware

 import (
+	"acc-server-manager/local/middleware/security"
 	"acc-server-manager/local/service"
 	"acc-server-manager/local/utl/jwt"
+	"acc-server-manager/local/utl/logging"
 	"strings"
+	"time"

 	"github.com/gofiber/fiber/v2"
 )
@@ -11,49 +14,125 @@ import (
 // AuthMiddleware provides authentication and permission middleware.
 type AuthMiddleware struct {
 	membershipService *service.MembershipService
+	securityMW        *security.SecurityMiddleware
 }

 // NewAuthMiddleware creates a new AuthMiddleware.
 func NewAuthMiddleware(ms *service.MembershipService) *AuthMiddleware {
 	return &AuthMiddleware{
 		membershipService: ms,
+		securityMW:        security.NewSecurityMiddleware(),
 	}
 }

-// Authenticate is a middleware for JWT authentication.
+// Authenticate is a middleware for JWT authentication with enhanced security.
 func (m *AuthMiddleware) Authenticate(ctx *fiber.Ctx) error {
+	// Log authentication attempt
+	ip := ctx.IP()
+	userAgent := ctx.Get("User-Agent")
+
 	authHeader := ctx.Get("Authorization")
 	if authHeader == "" {
-		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{"error": "Missing or malformed JWT"})
+		logging.Error("Authentication failed: missing Authorization header from IP %s", ip)
+		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+			"error": "Missing or malformed JWT",
+		})
 	}

 	parts := strings.Split(authHeader, " ")
 	if len(parts) != 2 || parts[0] != "Bearer" {
-		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{"error": "Missing or malformed JWT"})
+		logging.Error("Authentication failed: malformed Authorization header from IP %s", ip)
+		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+			"error": "Missing or malformed JWT",
+		})
 	}

-	claims, err := jwt.ValidateToken(parts[1])
+	// Validate token length to prevent potential attacks
+	token := parts[1]
+	if len(token) < 10 || len(token) > 2048 {
+		logging.Error("Authentication failed: invalid token length from IP %s", ip)
+		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+			"error": "Invalid or expired JWT",
+		})
+	}
+
+	claims, err := jwt.ValidateToken(token)
 	if err != nil {
-		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{"error": "Invalid or expired JWT"})
+		logging.Error("Authentication failed: invalid token from IP %s, User-Agent: %s, Error: %v", ip, userAgent, err)
+		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+			"error": "Invalid or expired JWT",
+		})
+	}
+
+	// Additional security: validate user ID format
+	if claims.UserID == "" || len(claims.UserID) < 10 {
+		logging.Error("Authentication failed: invalid user ID in token from IP %s", ip)
+		return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+			"error": "Invalid or expired JWT",
+		})
 	}

 	ctx.Locals("userID", claims.UserID)
+	ctx.Locals("authTime", time.Now())
+
+	logging.Info("User %s authenticated successfully from IP %s", claims.UserID, ip)
 	return ctx.Next()
 }

-// HasPermission is a middleware for checking user permissions.
+// HasPermission is a middleware for checking user permissions with enhanced logging.
 func (m *AuthMiddleware) HasPermission(requiredPermission string) fiber.Handler {
 	return func(ctx *fiber.Ctx) error {
 		userID, ok := ctx.Locals("userID").(string)
 		if !ok {
-			return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{"error": "Unauthorized"})
+			logging.Error("Permission check failed: no user ID in context from IP %s", ctx.IP())
+			return ctx.Status(fiber.StatusUnauthorized).JSON(fiber.Map{
+				"error": "Unauthorized",
+			})
+		}
+
+		// Validate permission parameter
+		if requiredPermission == "" {
+			logging.Error("Permission check failed: empty permission requirement")
+			return ctx.Status(fiber.StatusInternalServerError).JSON(fiber.Map{
+				"error": "Internal server error",
+			})
 		}

 		has, err := m.membershipService.HasPermission(ctx.UserContext(), userID, requiredPermission)
-		if err != nil || !has {
-			return ctx.Status(fiber.StatusForbidden).JSON(fiber.Map{"error": "Forbidden"})
+		if err != nil {
+			logging.Error("Permission check error for user %s, permission %s: %v", userID, requiredPermission, err)
+			return ctx.Status(fiber.StatusForbidden).JSON(fiber.Map{
+				"error": "Forbidden",
+			})
 		}

+		if !has {
+			logging.Error("Permission denied: user %s lacks permission %s, IP %s", userID, requiredPermission, ctx.IP())
+			return ctx.Status(fiber.StatusForbidden).JSON(fiber.Map{
+				"error": "Forbidden",
+			})
+		}
+
+		logging.Info("Permission granted: user %s has permission %s", userID, requiredPermission)
+		return ctx.Next()
+	}
+}
+
+// AuthRateLimit applies rate limiting specifically for authentication endpoints
+func (m *AuthMiddleware) AuthRateLimit() fiber.Handler {
+	return m.securityMW.AuthRateLimit()
+}
+
+// RequireHTTPS redirects HTTP requests to HTTPS in production
+func (m *AuthMiddleware) RequireHTTPS() fiber.Handler {
+	return func(ctx *fiber.Ctx) error {
+		if ctx.Protocol() != "https" && ctx.Get("X-Forwarded-Proto") != "https" {
+			// Allow HTTP in development/testing
+			if ctx.Hostname() != "localhost" && ctx.Hostname() != "127.0.0.1" {
+				httpsURL := "https://" + ctx.Hostname() + ctx.OriginalURL()
+				return ctx.Redirect(httpsURL, fiber.StatusMovedPermanently)
+			}
+		}
 		return ctx.Next()
 	}
 }
--- a/local/middleware/security/security.go
+++ b/local/middleware/security/security.go
@@ -0,0 +1,351 @@
+package security
+
+import (
+	"context"
+	"fmt"
+	"strings"
+	"sync"
+	"time"
+
+	"github.com/gofiber/fiber/v2"
+)
+
+// RateLimiter stores rate limiting information
+type RateLimiter struct {
+	requests map[string][]time.Time
+	mutex    sync.RWMutex
+}
+
+// NewRateLimiter creates a new rate limiter
+func NewRateLimiter() *RateLimiter {
+	rl := &RateLimiter{
+		requests: make(map[string][]time.Time),
+	}
+
+	// Clean up old entries every 5 minutes
+	go rl.cleanup()
+
+	return rl
+}
+
+// cleanup removes old entries from the rate limiter
+func (rl *RateLimiter) cleanup() {
+	ticker := time.NewTicker(5 * time.Minute)
+	defer ticker.Stop()
+
+	for range ticker.C {
+		rl.mutex.Lock()
+		now := time.Now()
+		for key, times := range rl.requests {
+			// Remove entries older than 1 hour
+			filtered := make([]time.Time, 0, len(times))
+			for _, t := range times {
+				if now.Sub(t) < time.Hour {
+					filtered = append(filtered, t)
+				}
+			}
+			if len(filtered) == 0 {
+				delete(rl.requests, key)
+			} else {
+				rl.requests[key] = filtered
+			}
+		}
+		rl.mutex.Unlock()
+	}
+}
+
+// SecurityMiddleware provides comprehensive security middleware
+type SecurityMiddleware struct {
+	rateLimiter *RateLimiter
+}
+
+// NewSecurityMiddleware creates a new security middleware
+func NewSecurityMiddleware() *SecurityMiddleware {
+	return &SecurityMiddleware{
+		rateLimiter: NewRateLimiter(),
+	}
+}
+
+// SecurityHeaders adds security headers to responses
+func (sm *SecurityMiddleware) SecurityHeaders() fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		// Prevent MIME type sniffing
+		c.Set("X-Content-Type-Options", "nosniff")
+
+		// Prevent clickjacking
+		c.Set("X-Frame-Options", "DENY")
+
+		// Enable XSS protection
+		c.Set("X-XSS-Protection", "1; mode=block")
+
+		// Prevent referrer leakage
+		c.Set("Referrer-Policy", "strict-origin-when-cross-origin")
+
+		// Content Security Policy
+		c.Set("Content-Security-Policy", "default-src 'self'; script-src 'self' 'unsafe-inline'; style-src 'self' 'unsafe-inline'; img-src 'self' data: https:; font-src 'self' data:; connect-src 'self'; frame-ancestors 'none'")
+
+		// Permissions Policy
+		c.Set("Permissions-Policy", "camera=(), microphone=(), geolocation=(), interest-cohort=()")
+
+		return c.Next()
+	}
+}
+
+// RateLimit implements rate limiting for API endpoints
+func (sm *SecurityMiddleware) RateLimit(maxRequests int, duration time.Duration) fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		ip := c.IP()
+		key := fmt.Sprintf("rate_limit:%s", ip)
+
+		sm.rateLimiter.mutex.Lock()
+		defer sm.rateLimiter.mutex.Unlock()
+
+		now := time.Now()
+		requests := sm.rateLimiter.requests[key]
+
+		// Remove requests older than duration
+		filtered := make([]time.Time, 0, len(requests))
+		for _, t := range requests {
+			if now.Sub(t) < duration {
+				filtered = append(filtered, t)
+			}
+		}
+
+		// Check if limit is exceeded
+		if len(filtered) >= maxRequests {
+			return c.Status(fiber.StatusTooManyRequests).JSON(fiber.Map{
+				"error":       "Rate limit exceeded",
+				"retry_after": duration.Seconds(),
+			})
+		}
+
+		// Add current request
+		filtered = append(filtered, now)
+		sm.rateLimiter.requests[key] = filtered
+
+		return c.Next()
+	}
+}
+
+// AuthRateLimit implements stricter rate limiting for authentication endpoints
+func (sm *SecurityMiddleware) AuthRateLimit() fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		ip := c.IP()
+		userAgent := c.Get("User-Agent")
+		key := fmt.Sprintf("%s:%s", ip, userAgent)
+
+		sm.rateLimiter.mutex.Lock()
+		defer sm.rateLimiter.mutex.Unlock()
+
+		now := time.Now()
+		requests := sm.rateLimiter.requests[key]
+
+		// Remove requests older than 15 minutes
+		filtered := make([]time.Time, 0, len(requests))
+		for _, t := range requests {
+			if now.Sub(t) < 15*time.Minute {
+				filtered = append(filtered, t)
+			}
+		}
+
+		// Check if limit is exceeded (5 requests per 15 minutes for auth)
+		if len(filtered) >= 5 {
+			return c.Status(fiber.StatusTooManyRequests).JSON(fiber.Map{
+				"error":       "Too many authentication attempts",
+				"retry_after": 900, // 15 minutes
+			})
+		}
+
+		// Add current request
+		filtered = append(filtered, now)
+		sm.rateLimiter.requests[key] = filtered
+
+		return c.Next()
+	}
+}
+
+// InputSanitization sanitizes user input to prevent XSS and injection attacks
+func (sm *SecurityMiddleware) InputSanitization() fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		// Sanitize query parameters
+		c.Request().URI().QueryArgs().VisitAll(func(key, value []byte) {
+			sanitized := sanitizeInput(string(value))
+			c.Request().URI().QueryArgs().Set(string(key), sanitized)
+		})
+
+		// Store original body for processing
+		if c.Method() == "POST" || c.Method() == "PUT" || c.Method() == "PATCH" {
+			body := c.Body()
+			if len(body) > 0 {
+				// Basic sanitization - remove potentially dangerous patterns
+				sanitized := sanitizeInput(string(body))
+				c.Request().SetBodyString(sanitized)
+			}
+		}
+
+		return c.Next()
+	}
+}
+
+// sanitizeInput removes potentially dangerous patterns from input
+func sanitizeInput(input string) string {
+	// Remove common XSS patterns
+	dangerous := []string{
+		"<script",
+		"</script>",
+		"javascript:",
+		"vbscript:",
+		"data:text/html",
+		"onload=",
+		"onerror=",
+		"onclick=",
+		"onmouseover=",
+		"onfocus=",
+		"onblur=",
+		"onchange=",
+		"onsubmit=",
+		"<iframe",
+		"<object",
+		"<embed",
+		"<link",
+		"<meta",
+		"<style",
+	}
+
+	result := strings.ToLower(input)
+	for _, pattern := range dangerous {
+		result = strings.ReplaceAll(result, pattern, "")
+	}
+
+	// If the sanitized version is very different, it might be malicious
+	if len(result) < len(input)/2 {
+		return ""
+	}
+
+	return input
+}
+
+// ValidateContentType ensures only expected content types are accepted
+func (sm *SecurityMiddleware) ValidateContentType(allowedTypes ...string) fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		if c.Method() == "POST" || c.Method() == "PUT" || c.Method() == "PATCH" {
+			contentType := c.Get("Content-Type")
+			if contentType == "" {
+				return c.Status(fiber.StatusBadRequest).JSON(fiber.Map{
+					"error": "Content-Type header is required",
+				})
+			}
+
+			// Check if content type is allowed
+			allowed := false
+			for _, allowedType := range allowedTypes {
+				if strings.Contains(contentType, allowedType) {
+					allowed = true
+					break
+				}
+			}
+
+			if !allowed {
+				return c.Status(fiber.StatusUnsupportedMediaType).JSON(fiber.Map{
+					"error": "Unsupported content type",
+				})
+			}
+		}
+
+		return c.Next()
+	}
+}
+
+// ValidateUserAgent blocks requests with suspicious or missing user agents
+func (sm *SecurityMiddleware) ValidateUserAgent() fiber.Handler {
+	suspiciousAgents := []string{
+		"sqlmap",
+		"nikto",
+		"nmap",
+		"masscan",
+		"gobuster",
+		"dirb",
+		"dirbuster",
+		"wpscan",
+		"curl/7.0", // Very old curl versions
+		"wget/1.0", // Very old wget versions
+	}
+
+	return func(c *fiber.Ctx) error {
+		userAgent := strings.ToLower(c.Get("User-Agent"))
+
+		// Block empty user agents
+		if userAgent == "" {
+			return c.Status(fiber.StatusBadRequest).JSON(fiber.Map{
+				"error": "User-Agent header is required",
+			})
+		}
+
+		// Block suspicious user agents
+		for _, suspicious := range suspiciousAgents {
+			if strings.Contains(userAgent, suspicious) {
+				return c.Status(fiber.StatusForbidden).JSON(fiber.Map{
+					"error": "Access denied",
+				})
+			}
+		}
+
+		return c.Next()
+	}
+}
+
+// RequestSizeLimit limits the size of incoming requests
+func (sm *SecurityMiddleware) RequestSizeLimit(maxSize int) fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		if c.Method() == "POST" || c.Method() == "PUT" || c.Method() == "PATCH" {
+			contentLength := c.Request().Header.ContentLength()
+			if contentLength > maxSize {
+				return c.Status(fiber.StatusRequestEntityTooLarge).JSON(fiber.Map{
+					"error":    "Request too large",
+					"max_size": maxSize,
+				})
+			}
+		}
+
+		return c.Next()
+	}
+}
+
+// LogSecurityEvents logs security-related events
+func (sm *SecurityMiddleware) LogSecurityEvents() fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		start := time.Now()
+
+		// Process request
+		err := c.Next()
+
+		// Log suspicious activity
+		status := c.Response().StatusCode()
+		if status == 401 || status == 403 || status == 429 {
+			duration := time.Since(start)
+			// In a real implementation, you would send this to your logging system
+			fmt.Printf("[SECURITY] %s %s %s %d %v %s\n",
+				time.Now().Format(time.RFC3339),
+				c.IP(),
+				c.Method(),
+				status,
+				duration,
+				c.Path(),
+			)
+		}
+
+		return err
+	}
+}
+
+// TimeoutMiddleware adds request timeout
+func (sm *SecurityMiddleware) TimeoutMiddleware(timeout time.Duration) fiber.Handler {
+	return func(c *fiber.Ctx) error {
+		ctx, cancel := context.WithTimeout(c.UserContext(), timeout)
+		defer cancel()
+
+		c.SetUserContext(ctx)
+
+		return c.Next()
+	}
+}