code cleanup

local/utl/logging/logger.go

@@ -6,12 +6,10 @@ import (
 )
 
 var (
-	// Legacy logger for backward compatibility
 	logger *Logger
 	once   sync.Once
 )
 
-// Logger maintains backward compatibility with existing code
 type Logger struct {
 	base        *BaseLogger
 	errorLogger *ErrorLogger
@@ -20,8 +18,6 @@ type Logger struct {
 	debugLogger *DebugLogger
 }
 
-// Initialize creates or gets the singleton logger instance
-// This maintains backward compatibility with existing code
 func Initialize() (*Logger, error) {
 	var err error
 	once.Do(func() {
@@ -31,13 +27,11 @@ func Initialize() (*Logger, error) {
 }
 
 func newLogger() (*Logger, error) {
-	// Initialize the base logger
 	baseLogger, err := InitializeBase("log")
 	if err != nil {
 		return nil, err
 	}
 
-	// Create the legacy logger wrapper
 	logger := &Logger{
 		base:        baseLogger,
 		errorLogger: GetErrorLogger(),
@@ -49,7 +43,6 @@ func newLogger() (*Logger, error) {
 	return logger, nil
 }
 
-// Close closes the logger
 func (l *Logger) Close() error {
 	if l.base != nil {
 		return l.base.Close()
@@ -57,7 +50,6 @@ func (l *Logger) Close() error {
 	return nil
 }
 
-// Legacy methods for backward compatibility
 func (l *Logger) log(level, format string, v ...interface{}) {
 	if l.base != nil {
 		l.base.LogWithCaller(LogLevel(level), 3, format, v...)
@@ -94,13 +86,10 @@ func (l *Logger) Panic(format string) {
 	}
 }
 
-// Global convenience functions for backward compatibility
-// These are now implemented in individual logger files to avoid redeclaration
 func LegacyInfo(format string, v ...interface{}) {
 	if logger != nil {
 		logger.Info(format, v...)
 	} else {
-		// Fallback to direct logger if legacy logger not initialized
 		GetInfoLogger().Log(format, v...)
 	}
 }
@@ -109,7 +98,6 @@ func LegacyError(format string, v ...interface{}) {
 	if logger != nil {
 		logger.Error(format, v...)
 	} else {
-		// Fallback to direct logger if legacy logger not initialized
 		GetErrorLogger().Log(format, v...)
 	}
 }
@@ -118,7 +106,6 @@ func LegacyWarn(format string, v ...interface{}) {
 	if logger != nil {
 		logger.Warn(format, v...)
 	} else {
-		// Fallback to direct logger if legacy logger not initialized
 		GetWarnLogger().Log(format, v...)
 	}
 }
@@ -127,7 +114,6 @@ func LegacyDebug(format string, v ...interface{}) {
 	if logger != nil {
 		logger.Debug(format, v...)
 	} else {
-		// Fallback to direct logger if legacy logger not initialized
 		GetDebugLogger().Log(format, v...)
 	}
 }
@@ -136,55 +122,42 @@ func Panic(format string) {
 	if logger != nil {
 		logger.Panic(format)
 	} else {
-		// Fallback to direct logger if legacy logger not initialized
 		GetErrorLogger().LogFatal(format)
 	}
 }
 
-// Enhanced logging convenience functions
-// These provide direct access to specialized logging functions
-
-// LogStartup logs application startup information
 func LogStartup(component string, message string) {
 	GetInfoLogger().LogStartup(component, message)
 }
 
-// LogShutdown logs application shutdown information
 func LogShutdown(component string, message string) {
 	GetInfoLogger().LogShutdown(component, message)
 }
 
-// LogOperation logs general operation information
 func LogOperation(operation string, details string) {
 	GetInfoLogger().LogOperation(operation, details)
 }
 
-// LogRequest logs incoming HTTP requests
 func LogRequest(method string, path string, userAgent string) {
 	GetInfoLogger().LogRequest(method, path, userAgent)
 }
 
-// LogResponse logs outgoing HTTP responses
 func LogResponse(method string, path string, statusCode int, duration string) {
 	GetInfoLogger().LogResponse(method, path, statusCode, duration)
 }
 
-// LogSQL logs SQL queries for debugging
 func LogSQL(query string, args ...interface{}) {
 	GetDebugLogger().LogSQL(query, args...)
 }
 
-// LogMemory logs memory usage information
 func LogMemory() {
 	GetDebugLogger().LogMemory()
 }
 
-// LogTiming logs timing information for performance debugging
 func LogTiming(operation string, duration interface{}) {
 	GetDebugLogger().LogTiming(operation, duration)
 }
 
-// GetLegacyLogger returns the legacy logger instance for backward compatibility
 func GetLegacyLogger() *Logger {
 	if logger == nil {
 		logger, _ = Initialize()
@@ -192,21 +165,17 @@ func GetLegacyLogger() *Logger {
 	return logger
 }
 
-// InitializeLogging initializes all logging components
 func InitializeLogging() error {
-	// Initialize legacy logger for backward compatibility
 	_, err := Initialize()
 	if err != nil {
 		return fmt.Errorf("failed to initialize legacy logger: %v", err)
 	}
 
-	// Pre-initialize all logger types to ensure separate log files
 	GetErrorLogger()
 	GetWarnLogger()
 	GetInfoLogger()
 	GetDebugLogger()
 
-	// Log successful initialization
 	Info("Logging system initialized successfully")
 
 	return nil