migrate leaderboard to driver ID-based wire format
This commit is contained in:
@@ -38,19 +38,20 @@ export function LeaderboardManager({ serverId, initialData }: LeaderboardManager
|
|||||||
const dirty = isDirty(draft, saved);
|
const dirty = isDirty(draft, saved);
|
||||||
|
|
||||||
const handleDriversChange = (newDrivers: LeaderboardDriver[]) => {
|
const handleDriversChange = (newDrivers: LeaderboardDriver[]) => {
|
||||||
const oldDrivers = draft.drivers;
|
const oldDriverIds = new Set(draft.drivers.map((d) => d.id));
|
||||||
|
|
||||||
// Build index map by matching drivers by initials (their stable identifier)
|
// Remap tracks: keep results for drivers that still exist, remove results for deleted drivers
|
||||||
// For each position in newDrivers, find where that driver was in oldDrivers
|
|
||||||
const indexMap = newDrivers.map((d) => {
|
|
||||||
const oldIndex = oldDrivers.findIndex((old) => old.initials === d.initials);
|
|
||||||
return oldIndex; // -1 if new driver, otherwise the old index
|
|
||||||
});
|
|
||||||
|
|
||||||
// If a driver was added (findIndex returns -1), it's new, start with DNS
|
|
||||||
const newTracks = draft.tracks.map((t) => ({
|
const newTracks = draft.tracks.map((t) => ({
|
||||||
...t,
|
...t,
|
||||||
results: indexMap.map((i) => (i === -1 ? 'DNS' : (t.results[i] ?? 'DNS')))
|
// Filter existing results to only include drivers still in newDrivers, add DNS for new drivers
|
||||||
|
results: [
|
||||||
|
// Keep existing results for drivers still in the list
|
||||||
|
...t.results.filter((r) => newDrivers.some((d) => d.id === r.driverId)),
|
||||||
|
// Add DNS for new drivers
|
||||||
|
...newDrivers
|
||||||
|
.filter((d) => !oldDriverIds.has(d.id))
|
||||||
|
.map((d) => ({ driverId: d.id, score: 'DNS' as const }))
|
||||||
|
]
|
||||||
}));
|
}));
|
||||||
|
|
||||||
setDraft({ ...draft, drivers: newDrivers, tracks: newTracks });
|
setDraft({ ...draft, drivers: newDrivers, tracks: newTracks });
|
||||||
|
|||||||
@@ -10,15 +10,17 @@ interface LeaderboardStandingsProps {
|
|||||||
export function LeaderboardStandings({ leaderboard }: LeaderboardStandingsProps) {
|
export function LeaderboardStandings({ leaderboard }: LeaderboardStandingsProps) {
|
||||||
const standings = useMemo<StandingsRow[]>(() => {
|
const standings = useMemo<StandingsRow[]>(() => {
|
||||||
return leaderboard.drivers
|
return leaderboard.drivers
|
||||||
.map((driver, idx) => {
|
.map((driver) => {
|
||||||
const trackResults = leaderboard.tracks.map((t) => t.results[idx] ?? 0);
|
const trackResults = leaderboard.tracks.map(
|
||||||
|
(t) => t.results.find((r) => r.driverId === driver.id)?.score ?? 'DNS'
|
||||||
|
);
|
||||||
const fastestLapCount = leaderboard.tracks.filter(
|
const fastestLapCount = leaderboard.tracks.filter(
|
||||||
(t) => t.fastestLapInitials === driver.initials
|
(t) => t.fastestLapDriverId === driver.id
|
||||||
).length;
|
).length;
|
||||||
const totalPoints =
|
const totalPoints =
|
||||||
trackResults.reduce((sum: number, r) => sum + (typeof r === 'number' ? r : 0), 0) +
|
trackResults.reduce((sum: number, r) => sum + (typeof r === 'number' ? r : 0), 0) +
|
||||||
fastestLapCount * leaderboard.flPoints.points;
|
fastestLapCount * leaderboard.flPoints.points;
|
||||||
return { driver, driverIndex: idx, totalPoints, trackResults, fastestLapCount };
|
return { driver, driverId: driver.id, totalPoints, trackResults, fastestLapCount };
|
||||||
})
|
})
|
||||||
.sort((a, b) => b.totalPoints - a.totalPoints);
|
.sort((a, b) => b.totalPoints - a.totalPoints);
|
||||||
}, [leaderboard]);
|
}, [leaderboard]);
|
||||||
@@ -54,7 +56,7 @@ export function LeaderboardStandings({ leaderboard }: LeaderboardStandingsProps)
|
|||||||
</thead>
|
</thead>
|
||||||
<tbody>
|
<tbody>
|
||||||
{standings.map((row, pos) => (
|
{standings.map((row, pos) => (
|
||||||
<tr key={row.driverIndex} className="border-b border-gray-700/50">
|
<tr key={row.driver.id} className="border-b border-gray-700/50">
|
||||||
<td className="py-2 pr-4 text-gray-400">{pos + 1}</td>
|
<td className="py-2 pr-4 text-gray-400">{pos + 1}</td>
|
||||||
<td className="py-2 pr-4">
|
<td className="py-2 pr-4">
|
||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
@@ -68,7 +70,7 @@ export function LeaderboardStandings({ leaderboard }: LeaderboardStandingsProps)
|
|||||||
</td>
|
</td>
|
||||||
{row.trackResults.map((result, ti) => {
|
{row.trackResults.map((result, ti) => {
|
||||||
const track = leaderboard.tracks[ti];
|
const track = leaderboard.tracks[ti];
|
||||||
const isFl = track.fastestLapInitials === row.driver.initials;
|
const isFl = track.fastestLapDriverId === row.driver.id;
|
||||||
return (
|
return (
|
||||||
<td key={ti} className="px-2 py-2 text-center">
|
<td key={ti} className="px-2 py-2 text-center">
|
||||||
<span
|
<span
|
||||||
|
|||||||
@@ -36,13 +36,13 @@ export function DriversEditor({ drivers, onChange }: DriversEditorProps) {
|
|||||||
};
|
};
|
||||||
|
|
||||||
const add = () => {
|
const add = () => {
|
||||||
onChange([...drivers, { name: 'New Driver', initials: 'ND', color: randomColor() }]);
|
onChange([...drivers, { id: crypto.randomUUID(), name: 'New Driver', initials: 'ND', color: randomColor() }]);
|
||||||
};
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div className="space-y-3">
|
<div className="space-y-3">
|
||||||
{drivers.map((driver, i) => (
|
{drivers.map((driver, i) => (
|
||||||
<div key={i} className="flex items-center gap-3 rounded-lg bg-gray-700 p-3">
|
<div key={driver.id} className="flex items-center gap-3 rounded-lg bg-gray-700 p-3">
|
||||||
<div className="flex flex-col gap-1">
|
<div className="flex flex-col gap-1">
|
||||||
<button
|
<button
|
||||||
onClick={() => moveUp(i)}
|
onClick={() => moveUp(i)}
|
||||||
|
|||||||
@@ -53,9 +53,14 @@ export function TracksEditor({ tracks, drivers, pointsTable, onChange }: TracksE
|
|||||||
onChange(tracks.map((t, i) => (i === index ? { ...t, ...patch } : t)));
|
onChange(tracks.map((t, i) => (i === index ? { ...t, ...patch } : t)));
|
||||||
};
|
};
|
||||||
|
|
||||||
const updateResult = (trackIndex: number, driverIndex: number, value: ResultValue) => {
|
const updateResult = (trackIndex: number, driverId: string, value: ResultValue) => {
|
||||||
const newResults = [...tracks[trackIndex].results];
|
const newResults = [...tracks[trackIndex].results];
|
||||||
newResults[driverIndex] = value;
|
const existingIndex = newResults.findIndex((r) => r.driverId === driverId);
|
||||||
|
if (existingIndex >= 0) {
|
||||||
|
newResults[existingIndex] = { driverId, score: value };
|
||||||
|
} else {
|
||||||
|
newResults.push({ driverId, score: value });
|
||||||
|
}
|
||||||
updateTrack(trackIndex, { results: newResults });
|
updateTrack(trackIndex, { results: newResults });
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -68,8 +73,8 @@ export function TracksEditor({ tracks, drivers, pointsTable, onChange }: TracksE
|
|||||||
...tracks,
|
...tracks,
|
||||||
{
|
{
|
||||||
name: `Race ${tracks.length + 1}`,
|
name: `Race ${tracks.length + 1}`,
|
||||||
results: drivers.map(() => 'DNS' as const),
|
results: drivers.map((d) => ({ driverId: d.id, score: 'DNS' as const })),
|
||||||
fastestLapInitials: ''
|
fastestLapDriverId: ''
|
||||||
}
|
}
|
||||||
]);
|
]);
|
||||||
};
|
};
|
||||||
@@ -89,13 +94,13 @@ export function TracksEditor({ tracks, drivers, pointsTable, onChange }: TracksE
|
|||||||
<div className="flex items-center gap-2">
|
<div className="flex items-center gap-2">
|
||||||
<label className="text-xs text-gray-400">FL Driver:</label>
|
<label className="text-xs text-gray-400">FL Driver:</label>
|
||||||
<select
|
<select
|
||||||
value={track.fastestLapInitials}
|
value={track.fastestLapDriverId}
|
||||||
onChange={(e) => updateTrack(ti, { fastestLapInitials: e.target.value })}
|
onChange={(e) => updateTrack(ti, { fastestLapDriverId: e.target.value })}
|
||||||
className="rounded bg-gray-600 px-2 py-1 text-sm text-white"
|
className="rounded bg-gray-600 px-2 py-1 text-sm text-white"
|
||||||
>
|
>
|
||||||
<option value="">—</option>
|
<option value="">—</option>
|
||||||
{drivers.map((d) => (
|
{drivers.map((d) => (
|
||||||
<option key={d.initials} value={d.initials}>
|
<option key={d.id} value={d.id}>
|
||||||
{d.initials} ({d.name})
|
{d.initials} ({d.name})
|
||||||
</option>
|
</option>
|
||||||
))}
|
))}
|
||||||
@@ -114,8 +119,8 @@ export function TracksEditor({ tracks, drivers, pointsTable, onChange }: TracksE
|
|||||||
<p className="text-xs text-gray-500">Add drivers first to enter results.</p>
|
<p className="text-xs text-gray-500">Add drivers first to enter results.</p>
|
||||||
) : (
|
) : (
|
||||||
<div className="space-y-1">
|
<div className="space-y-1">
|
||||||
{drivers.map((driver, di) => (
|
{drivers.map((driver) => (
|
||||||
<div key={di} className="flex items-center gap-3">
|
<div key={driver.id} className="flex items-center gap-3">
|
||||||
<div className="flex w-40 items-center gap-2">
|
<div className="flex w-40 items-center gap-2">
|
||||||
<div
|
<div
|
||||||
className="h-3 w-3 shrink-0 rounded-full"
|
className="h-3 w-3 shrink-0 rounded-full"
|
||||||
@@ -125,9 +130,9 @@ export function TracksEditor({ tracks, drivers, pointsTable, onChange }: TracksE
|
|||||||
</div>
|
</div>
|
||||||
<div className="w-24">
|
<div className="w-24">
|
||||||
<ResultInput
|
<ResultInput
|
||||||
value={track.results[di] ?? 0}
|
value={track.results.find((r) => r.driverId === driver.id)?.score ?? 'DNS'}
|
||||||
pointsTable={pointsTable}
|
pointsTable={pointsTable}
|
||||||
onChange={(v) => updateResult(ti, di, v)}
|
onChange={(v) => updateResult(ti, driver.id, v)}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ export const resultValueSchema = z.union([z.literal('DNF'), z.literal('DNS'), z.
|
|||||||
export type ResultValue = z.infer<typeof resultValueSchema>;
|
export type ResultValue = z.infer<typeof resultValueSchema>;
|
||||||
|
|
||||||
export const leaderboardDriverSchema = z.object({
|
export const leaderboardDriverSchema = z.object({
|
||||||
|
id: z.string(),
|
||||||
name: z.string().min(1),
|
name: z.string().min(1),
|
||||||
color: z.string().regex(/^#[0-9a-fA-F]{6}$/),
|
color: z.string().regex(/^#[0-9a-fA-F]{6}$/),
|
||||||
initials: z.string().min(1).max(10)
|
initials: z.string().min(1).max(10)
|
||||||
@@ -26,8 +27,8 @@ export type FlPoints = z.infer<typeof flPointsSchema>;
|
|||||||
|
|
||||||
export const leaderboardTrackSchema = z.object({
|
export const leaderboardTrackSchema = z.object({
|
||||||
name: z.string().min(1),
|
name: z.string().min(1),
|
||||||
results: z.array(resultValueSchema),
|
results: z.array(z.object({ driverId: z.string(), score: resultValueSchema })),
|
||||||
fastestLapInitials: z.string()
|
fastestLapDriverId: z.string()
|
||||||
});
|
});
|
||||||
export type LeaderboardTrack = z.infer<typeof leaderboardTrackSchema>;
|
export type LeaderboardTrack = z.infer<typeof leaderboardTrackSchema>;
|
||||||
|
|
||||||
@@ -49,7 +50,7 @@ export const emptyLeaderboard: Leaderboard = {
|
|||||||
// Client-side derived type — never sent to API
|
// Client-side derived type — never sent to API
|
||||||
export type StandingsRow = {
|
export type StandingsRow = {
|
||||||
driver: LeaderboardDriver;
|
driver: LeaderboardDriver;
|
||||||
driverIndex: number;
|
driverId: string;
|
||||||
totalPoints: number;
|
totalPoints: number;
|
||||||
trackResults: ResultValue[];
|
trackResults: ResultValue[];
|
||||||
fastestLapCount: number;
|
fastestLapCount: number;
|
||||||
|
|||||||
Reference in New Issue
Block a user